netdev - Re: [PATCH] net: macb: Set MDIO clock divisor for pclk higher than 160MHz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1636986a-9748-4a37-aaf0-945590c042c8@lunn.ch>
Date:   Fri, 17 Mar 2023 15:28:17 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Nicolas Ferre <nicolas.ferre@...rochip.com>
Cc:     Bartosz Wawrzyniak <bwawrzyn@...co.com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        claudiu.beznea@...rochip.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, xe-linux-external@...co.com,
        danielwa@...co.com, olicht@...co.com, mawierzb@...co.com
Subject: Re: [PATCH] net: macb: Set MDIO clock divisor for pclk higher than
 160MHz

> I see them existing in all variants of "GEM" controller and the older "MACB"
> uses a different path so I think that we are save enabling these values.

Great. Thanks for checking.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

FYI: Documentation/devicetree/bindings/net/mdio.yaml defines:

  clock-frequency:
    description:
      Desired MDIO bus clock frequency in Hz. Values greater than IEEE 802.3
      defined 2.5MHz should only be used when all devices on the bus support
      the given clock speed.

So you could if you want make the bus speed configurable. Some devices
do work at faster than 2.5MHz, which can be nice if you have a lot of
traffic, e.g. an Ethernet switch, or raw TDR cable test data.

    Andrew