netdev - Re: [PATCH] net: phy: hisi-festa: Add support for HiSilicon Festa PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Mar 2023 17:28:35 +0100
From:   Francois Romieu <romieu@...zoreil.com>
To:     David Yang <mmyangfl@...il.com>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: phy: hisi-festa: Add support for HiSilicon Festa
 PHYs

Heiner Kallweit <hkallweit1@...il.com> :
> On 17.03.2023 15:30, David Yang wrote:
[...]
> > diff --git a/drivers/net/phy/hisi-festa.c b/drivers/net/phy/hisi-festa.c
> > new file mode 100644
> > index 000000000..ab54ed3ca
> > --- /dev/null
> > +++ b/drivers/net/phy/hisi-festa.c
[...]
> > +static int hisi_festa_patch_fw(struct phy_device *phydev)

This function can fail...

[...]
> > +static int hisi_festa_config_init(struct phy_device *phydev)
> > +{
> > +	hisi_festa_patch_fw(phydev);
> > +	/* ok, use programmed firmware */
> > +	return 0;

... but nobody cares.

This lack of consistency may also be fixed once Heiner's remarks are
answered.

-- 
Ueimor