netdev - Re: [PATCH net v2] net: xdp: don't call notifiers during driver init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167902801950.7493.7591082991842203309.git-patchwork-notify@kernel.org>
Date:   Fri, 17 Mar 2023 04:40:19 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, ast@...nel.org, daniel@...earbox.net,
        hawk@...nel.org, john.fastabend@...il.com, lorenzo@...nel.org,
        tariqt@...dia.com, bpf@...r.kernel.org
Subject: Re: [PATCH net v2] net: xdp: don't call notifiers during driver init

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu, 16 Mar 2023 15:02:34 -0700 you wrote:
> Drivers will commonly perform feature setting during init, if they use
> the xdp_set_features_flag() helper they'll likely run into an ASSERT_RTNL()
> inside call_netdevice_notifiers_info().
> 
> Don't call the notifier until the device is actually registered.
> Nothing should be tracking the device until its registered and
> after its unregistration has started.
> 
> [...]

Here is the summary with links:
  - [net,v2] net: xdp: don't call notifiers during driver init
    https://git.kernel.org/netdev/net/c/769639c1fe8a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html