netdev - Re: Re: [PATCH] octeontx2-vf: Add missing free for alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20230317063403.17970-1-jiasheng@iscas.ac.cn>
Date:   Fri, 17 Mar 2023 14:34:03 +0800
From:   Jiasheng Jiang <jiasheng@...as.ac.cn>
To:     kuba@...nel.org
Cc:     sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com,
        hkelam@...vell.com, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, richardcochran@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jiasheng Jiang <jiasheng@...as.ac.cn>
Subject: Re: Re: [PATCH] octeontx2-vf: Add missing free for alloc_percpu

On Fri, Mar 17, 2023 at 12:24:46AM +0800, Jakub Kicinski wrote:
> On Thu, 16 Mar 2023 10:39:11 +0800 Jiasheng Jiang wrote:
>> +	if (vf->hw.lmt_info)
>> +		free_percpu(vf->hw.lmt_info);
>>  	if (test_bit(CN10K_LMTST, &vf->hw.cap_flag))
>>  		qmem_free(vf->dev, vf->dync_lmt);
>>  	otx2_detach_resources(&vf->mbox);
>> @@ -762,6 +764,8 @@ static void otx2vf_remove(struct pci_dev *pdev)
>>  	otx2_shutdown_tc(vf);
>>  	otx2vf_disable_mbox_intr(vf);
>>  	otx2_detach_resources(&vf->mbox);
>> +	if (vf->hw.lmt_info)
>> +		free_percpu(vf->hw.lmt_info);
> 
> No need for the if () checks, free_percpu() seems to handle NULL just
> fine.

I will submit a v2 removing the checks.

Thanks,
Jiang