netdev - Re: [PATCH v2 1/2] net: mdio: fix owner field for mdio buses registered using device-tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBXWbPNHn0si8a4g@corigine.com>
Date:   Sat, 18 Mar 2023 16:19:08 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, Maxime Bizon <mbizon@...ebox.fr>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Calvin Johnson <calvin.johnson@....nxp.com>,
        Grant Likely <grant.likely@....com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] net: mdio: fix owner field for mdio buses
 registered using device-tree

On Thu, Mar 16, 2023 at 04:33:16PM -0700, Florian Fainelli wrote:
> From: Maxime Bizon <mbizon@...ebox.fr>
> 
> Bus ownership is wrong when using of_mdiobus_register() to register an mdio
> bus. That function is not inline, so when it calls mdiobus_register() the wrong
> THIS_MODULE value is captured.
> 
> Signed-off-by: Maxime Bizon <mbizon@...ebox.fr>
> Fixes: 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from PHYs")
> [florian: fix kdoc, added Fixes tag]
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>