netdev - Re: [PATCH net] vmxnet3: use gro callback when UPT is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Mar 2023 19:43:39 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ronak Doshi <doshir@...are.com>
Cc:     Yunsheng Lin <linyunsheng@...wei.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Pv-drivers <Pv-drivers@...are.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Guolin Yang <gyang@...are.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] vmxnet3: use gro callback when UPT is enabled

On Fri, 17 Mar 2023 20:27:50 +0000 Ronak Doshi wrote:
> I don’t think holding this patch to investigate why it takes longer in GRO is worthwhile.
> That is a separate issue. UPT patches are already upstreamed to Linux and cross-ported to
> relevant distros for customers to use. We need to apply this patch to avoid the performance
> degradation in UPT mode as LRO is not available on UPT device.
> 
> I don’t see a functional issue with this patch. In UPT as LRO is not available, it needs to use GRO.

Fine by me, FWIW, but please respin the patch and feed some of 
the discussion into the commit message.