netdev - RE: [PATCH net-next] net/packet: remove po->xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64162267eac9b_397cf2208fa@willemb.c.googlers.com.notmuch>
Date:   Sat, 18 Mar 2023 16:43:19 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        Eric Dumazet <edumazet@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Daniel Borkmann <daniel@...earbox.net>
Subject: RE: [PATCH net-next] net/packet: remove po->xmit

Eric Dumazet wrote:
> Use PACKET_SOCK_QDISC_BYPASS atomic bit instead of a pointer.
> 
> This removes one indirect call in fast path,
> and READ_ONCE()/WRITE_ONCE() annotations as well.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Suggested-by: Willem de Bruijn <willemb@...gle.com>
> Cc: Daniel Borkmann <daniel@...earbox.net>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>