netdev - Re: [PATCH net-next 4/4] ynl: ethtool testing tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKH8qBtrMtwGexJ2Zd7YX1K3CScVStbXHSyq-hF2w2Zet3e=Lw@mail.gmail.com>
Date:   Mon, 20 Mar 2023 11:03:29 -0700
From:   Stanislav Fomichev <sdf@...gle.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com
Subject: Re: [PATCH net-next 4/4] ynl: ethtool testing tool

On Fri, Mar 17, 2023 at 9:23 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri, 17 Mar 2023 17:23:40 -0700 Stanislav Fomichev wrote:
> > diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py
> > index 6c1a59cef957..2562e2cd4768 100644
> > --- a/tools/net/ynl/lib/ynl.py
> > +++ b/tools/net/ynl/lib/ynl.py
> > @@ -477,6 +477,19 @@ genl_family_name_to_id = None
> >
> >                  self.handle_ntf(nl_msg, gm)
> >
> > +    def operation_do_attributes(self, name):
> > +      """
> > +      For a given operation name, find and return a supported
> > +      set of attributes (as a dict).
> > +      """
> > +      op = self.find_operation(name)
> > +      if not op:
> > +        return None
> > +
> > +      attrs = op['do']['request']['attributes'].copy()
> > +      attrs.remove('header') # not user-provided
>
> 'header' is ethtool specific tho, right?

Good point, will move to the binary. (but as I mentioned in the cover
letter, not sure we need to really put that into the repo, up to you).

> > +      return attrs