netdev - Re: [PATCH 2/4] net: dsa: b53: mmap: add more BCM63xx SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBi56yI4CnY2AAtH@corigine.com>
Date:   Mon, 20 Mar 2023 20:54:19 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Álvaro Fernández Rojas <noltari@...il.com>
Cc:     f.fainelli@...il.com, andrew@...n.ch, olteanv@...il.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] net: dsa: b53: mmap: add more BCM63xx SoCs

On Mon, Mar 20, 2023 at 04:50:22PM +0100, Álvaro Fernández Rojas wrote:
> BCM6318, BCM6362 and BCM63268 are SoCs with a B53 MMAP switch.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>
> ---
>  drivers/net/dsa/b53/b53_mmap.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mmap.c
> index 70887e0aece3..464c77e10f60 100644
> --- a/drivers/net/dsa/b53/b53_mmap.c
> +++ b/drivers/net/dsa/b53/b53_mmap.c
> @@ -331,8 +331,11 @@ static void b53_mmap_shutdown(struct platform_device *pdev)
>  
>  static const struct of_device_id b53_mmap_of_table[] = {
>  	{ .compatible = "brcm,bcm3384-switch" },
> +	{ .compatible = "brcm,bcm6318-switch" },
>  	{ .compatible = "brcm,bcm6328-switch" },
> +	{ .compatible = "brcm,bcm6362-switch" },
>  	{ .compatible = "brcm,bcm6368-switch" },
> +	{ .compatible = "brcm,bcm63268-switch" },

This patch adds support to this driver for "brcm,bcm63268-switch".
However, less I am mistaken, this support doesn't work without
patches 3/4 and 4/4 of this series.

I think it would be better to re-range this series so
that support for "brcm,bcm63268-switch" works when it is
added to/enabled in the driver.

>  	{ .compatible = "brcm,bcm63xx-switch" },
>  	{ /* sentinel */ },
>  };
> -- 
> 2.30.2
>