netdev - Re: [PATCH] can: usb: f81604: add Fintek F81604 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CRB4VW859JPC.253TLOWY0XT6S@den-dk-m31857>
Date:   Mon, 20 Mar 2023 10:21:07 +0000
From:   <Steen.Hegelund@...rochip.com>
To:     <peter_hong@...tek.com.tw>, <wg@...ndegger.com>,
        <mkl@...gutronix.de>
CC:     <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <mailhol.vincent@...adoo.fr>,
        <frank.jungclaus@....eu>, <linux-kernel@...r.kernel.org>,
        <linux-can@...r.kernel.org>, <netdev@...r.kernel.org>,
        <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH] can: usb: f81604: add Fintek F81604 support

Hi Peter,

Besides what Michal has mentioned, I noted this:

On Fri Mar 17, 2023 at 10:33 AM CET, Ji-Ze Hong (Peter Hong) wrote:
> [Some people who received this message don't often get email from peter_hong@...tek.com.tw. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> This patch add support for Fintek USB to 2CAN controller support.
>
> Signed-off-by: Ji-Ze Hong (Peter Hong) <peter_hong@...tek.com.tw>
> ---

..snip...

> +static int f81604_prepare_urbs(struct net_device *netdev)
> +{
> +       static u8 bulk_in_addr[F81604_MAX_DEV] = { 0x82, 0x84 };
> +       static u8 bulk_out_addr[F81604_MAX_DEV] = { 0x01, 0x03 };
> +       static u8 int_in_addr[F81604_MAX_DEV] = { 0x81, 0x83 };

These 3 should be made const

> +       struct f81604_port_priv *priv;
> +       int id;

..snip...

> +       int i;
> +MODULE_AUTHOR("Ji-Ze Hong (Peter Hong) <peter_hong@...tek.com.tw>");
> +MODULE_DESCRIPTION("Fintek F81604 USB to 2xCANBUS");
> +MODULE_LICENSE("GPL");
> --
> 2.17.1


BR
Steen