netdev - Re: [PATCH net v2 0/2] Fix PHY handle no longer parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBmFVZD6rBA45hu3@shell.armlinux.org.uk>
Date:   Tue, 21 Mar 2023 10:22:13 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     "Sit, Michael Wei Hong" <michael.wei.hong.sit@...el.com>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        "Ong, Boon Leong" <boon.leong.ong@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Looi, Hong Aun" <hong.aun.looi@...el.com>,
        "Voon, Weifeng" <weifeng.voon@...el.com>,
        "Lai, Peter Jun Ann" <peter.jun.ann.lai@...el.com>
Subject: Re: [PATCH net v2 0/2] Fix PHY handle no longer parsing

On Tue, Mar 21, 2023 at 08:37:48AM +0000, Sit, Michael Wei Hong wrote:
> 
> 
> > -----Original Message-----
> > From: Russell King <linux@...linux.org.uk>
> > Sent: Saturday, March 18, 2023 4:54 AM
> > To: Sit, Michael Wei Hong <michael.wei.hong.sit@...el.com>
> > Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>; Alexandre
> > Torgue <alexandre.torgue@...s.st.com>; Jose Abreu
> > <joabreu@...opsys.com>; David S . Miller
> > <davem@...emloft.net>; Eric Dumazet
> > <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>;
> > Paolo Abeni <pabeni@...hat.com>; Maxime Coquelin
> > <mcoquelin.stm32@...il.com>; Ong, Boon Leong
> > <boon.leong.ong@...el.com>; netdev@...r.kernel.org; linux-
> > stm32@...md-mailman.stormreply.com; linux-arm-
> > kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; Looi,
> > Hong Aun <hong.aun.looi@...el.com>; Voon, Weifeng
> > <weifeng.voon@...el.com>; Lai, Peter Jun Ann
> > <peter.jun.ann.lai@...el.com>
> > Subject: Re: [PATCH net v2 0/2] Fix PHY handle no longer parsing
> > 
> > On Tue, Mar 14, 2023 at 03:02:06PM +0800, Michael Sit Wei Hong
> > wrote:
> > > After the fixed link support was introduced, it is observed that
> > PHY
> > > no longer attach to the MAC properly.
> > 
> > You are aware, I hope, that fixed-link and having a PHY are
> > mutually exclusive?
> > 
> > In other words, you can't use fixed-link to specify parameters for
> > a PHY.
> > 
> Yes but when the fixed-link support code was added, all our non
> fixed-link devices are not attaching the PHYs to the MACs, hence
> the reason for this patch series, to ensure both fixed-link and
> non fixed-link scenarios work properly.

Ah, it's the "there should be a PHY here" case you're trying to cater
for, rather than actually a fixed-link.

So, how about adding a helper that is basically:

bool phylink_expects_phy(struct phylink *phylink)
{
	return pl->cfg_link_an_mode == MLO_AN_PHY;
}
EXPORT_SYMBOL_GPL(phylink_expects_phy);

and use that to test whether you need to manually find a PHY to attach,
rather than trying to detect whether a fixed-link stanza appears in
firmware?

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!