netdev - Re: [PATCH v2 1/3] net: mvpp2: classifier flow fix fragmentation flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33b5d0dd04c86e4186c9fb8236b874c6d8c11e65.camel@redhat.com>
Date:   Tue, 21 Mar 2023 11:29:23 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Sven Auhagen <Sven.Auhagen@...eatech.de>, netdev@...r.kernel.org
Cc:     mw@...ihalf.com, linux@...linux.org.uk, kuba@...nel.org,
        davem@...emloft.net, maxime.chevallier@...tlin.com
Subject: Re: [PATCH v2 1/3] net: mvpp2: classifier flow fix fragmentation
 flags

Hello,

On Sun, 2023-03-19 at 07:00 +0100, Sven Auhagen wrote:
> Add missing IP Fragmentation Flag.
> 
> Change from v1:
> 	* Added the fixes tag
> 	* Drop the MVPP22_CLS_HEK_TAGGED change from the patch
> 
> Fixes: f9358e12a0af ("net: mvpp2: split ingress traffic into multiple flows")
> Signed-off-by: Sven Auhagen <sven.auhagen@...eatech.de>

The code LGTM, but this series has few formal glitches. It would be
great if you could address them:
- please add a cover letter
- insert a '---' separator between the commit message and the diff
itself
- move the changelog after the '---' separator
- your SoB tag uses lowercase case for the email address, while the
sender email address uses camel case and checkpatch complains (for no
reasons, but you can avoid that using camel case in the SoB, too.

Thanks,

Paolo