netdev - Re: [PATCH net-next] net: dsa: qca8k: remove assignment of an_enabled in pcs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBmgxwbsPwv1HUdP@shell.armlinux.org.uk>
Date:   Tue, 21 Mar 2023 12:19:19 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Jonathan McDowell <noodles@...th.li>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: qca8k: remove assignment of
 an_enabled in pcs_get_state()

On Tue, Mar 21, 2023 at 12:47:08PM +0100, Paolo Abeni wrote:
> Hello,
> 
> On Sun, 2023-03-19 at 12:33 +0000, Russell King (Oracle) wrote:
> > pcs_get_state() implementations are not supposed to alter an_enabled.
> > Remove this assignment.
> > 
> > Fixes: b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB")
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> 
> Any special reason to target the net-next tree? the fixes commit is
> quite old, and this looks like a -net candidate to me?!?

It's a correctness issue rather than a bug fix, so I don't see why it
should be applied to a -rc kernel.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!