netdev - Re: [PATCH net-next v1 6/8] ice: add individual interrupt allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 Mar 2023 23:48:55 +0800
From:   kernel test robot <lkp@...el.com>
To:     Piotr Raczynski <piotr.raczynski@...el.com>,
        intel-wired-lan@...ts.osuosl.org
Cc:     oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
        michal.swiatkowski@...el.com, shiraz.saleem@...el.com,
        jacob.e.keller@...el.com, sridhar.samudrala@...el.com,
        jesse.brandeburg@...el.com, aleksander.lobakin@...el.com,
        lukasz.czapnik@...el.com,
        Piotr Raczynski <piotr.raczynski@...el.com>,
        Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Subject: Re: [PATCH net-next v1 6/8] ice: add individual interrupt allocation

Hi Piotr,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Piotr-Raczynski/ice-move-interrupt-related-code-to-separate-file/20230321-202438
patch link:    https://lore.kernel.org/r/20230321122138.3151670-7-piotr.raczynski%40intel.com
patch subject: [PATCH net-next v1 6/8] ice: add individual interrupt allocation
config: i386-randconfig-a011-20230320 (https://download.01.org/0day-ci/archive/20230321/202303212327.g08d8Z7h-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/6dc6aed8cfd670558d6c07ac957f342d1643f115
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Piotr-Raczynski/ice-move-interrupt-related-code-to-separate-file/20230321-202438
        git checkout 6dc6aed8cfd670558d6c07ac957f342d1643f115
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 olddefconfig
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303212327.g08d8Z7h-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: drivers/net/ethernet/intel/ice/ice_base.o: in function `ice_free_q_vector':
>> drivers/net/ethernet/intel/ice/ice_base.c:199: undefined reference to `ice_get_vf_ctrl_vsi'
   ld: drivers/net/ethernet/intel/ice/ice_base.o: in function `ice_vsi_alloc_q_vector':
   drivers/net/ethernet/intel/ice/ice_base.c:127: undefined reference to `ice_get_vf_ctrl_vsi'


vim +199 drivers/net/ethernet/intel/ice/ice_base.c

   163	
   164	/**
   165	 * ice_free_q_vector - Free memory allocated for a specific interrupt vector
   166	 * @vsi: VSI having the memory freed
   167	 * @v_idx: index of the vector to be freed
   168	 */
   169	static void ice_free_q_vector(struct ice_vsi *vsi, int v_idx)
   170	{
   171		struct ice_q_vector *q_vector;
   172		struct ice_pf *pf = vsi->back;
   173		struct ice_tx_ring *tx_ring;
   174		struct ice_rx_ring *rx_ring;
   175		struct device *dev;
   176	
   177		dev = ice_pf_to_dev(pf);
   178		if (!vsi->q_vectors[v_idx]) {
   179			dev_dbg(dev, "Queue vector at index %d not found\n", v_idx);
   180			return;
   181		}
   182		q_vector = vsi->q_vectors[v_idx];
   183	
   184		ice_for_each_tx_ring(tx_ring, q_vector->tx)
   185			tx_ring->q_vector = NULL;
   186		ice_for_each_rx_ring(rx_ring, q_vector->rx)
   187			rx_ring->q_vector = NULL;
   188	
   189		/* only VSI with an associated netdev is set up with NAPI */
   190		if (vsi->netdev)
   191			netif_napi_del(&q_vector->napi);
   192	
   193		/* release MSIX interrupt if q_vector had interrupt allocated */
   194		if (q_vector->irq.index < 0)
   195			goto free_q_vector;
   196	
   197		/* only free last VF ctrl vsi interrupt */
   198		if (vsi->type == ICE_VSI_CTRL && vsi->vf &&
 > 199		    ice_get_vf_ctrl_vsi(pf, vsi))
   200			goto free_q_vector;
   201	
   202		ice_free_irq(pf, q_vector->irq);
   203	
   204	free_q_vector:
   205		devm_kfree(dev, q_vector);
   206		vsi->q_vectors[v_idx] = NULL;
   207	}
   208	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests