netdev - Re: [PATCH net] erspan: do not use skb_mac_header() in ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJzniaHGYDWL4o8BWp+FBMH_RMaZuCzt+uh5gHicJQ+Pw@mail.gmail.com>
Date:   Tue, 21 Mar 2023 09:26:45 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        eric.dumazet@...il.com, syzbot <syzkaller@...glegroups.com>
Subject: Re: [PATCH net] erspan: do not use skb_mac_header() in ndo_start_xmit()

On Mon, Mar 20, 2023 at 11:53 PM Simon Horman <simon.horman@...igine.com> wrote:
>

> Hi Eric,
>
> A quick grep seems to indicate there may be similar problems elsewhere.
> I didn't check them in any detail and I'm wondering if you might have.

I have a patch series of three, but for net-next.

My plan is to remove skb_reset_mac_header() from __dev_queue_xmit :)

>
> In any case, this looks good.
>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>