netdev - Re: [PATCH net] mlxsw: spectrum_fid: Fix incorrect local port type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBneztl7Q2srQzYT@corigine.com>
Date:   Tue, 21 Mar 2023 17:43:58 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Petr Machata <petrm@...dia.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        Ido Schimmel <idosch@...dia.com>,
        Amit Cohen <amcohen@...dia.com>, mlxsw@...dia.com,
        Danielle Ratson <danieller@...dia.com>
Subject: Re: [PATCH net] mlxsw: spectrum_fid: Fix incorrect local port type

On Tue, Mar 21, 2023 at 12:42:00PM +0100, Petr Machata wrote:
> From: Ido Schimmel <idosch@...dia.com>
> 
> Local port is a 10-bit number, but it was mistakenly stored in a u8,
> resulting in firmware errors when using a netdev corresponding to a
> local port higher than 255.
> 
> Fix by storing the local port in u16, as is done in the rest of the
> code.
> 
> Fixes: bf73904f5fba ("mlxsw: Add support for 802.1Q FID family")
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> Reviewed-by: Danielle Ratson <danieller@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>