netdev - Re: [PATCH net-next 0/3] net: remove some skb_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230321171333.t4u6z2n5ex76h3ot@skbuf>
Date:   Tue, 21 Mar 2023 19:13:33 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Simon Horman <simon.horman@...igine.com>,
        netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 0/3] net: remove some skb_mac_header assumptions

Hi Eric,

On Tue, Mar 21, 2023 at 04:45:16PM +0000, Eric Dumazet wrote:
> Historically, we tried o maintain skb_mac_header available in most of
> networking paths.
> 
> When reaching ndo_start_xmit() handlers, skb_mac_header() should always
> be skb->data.
> 
> With recent additions of skb_mac_header_was_set() and 
> DEBUG_NET_WARN_ON_ONCE() in skb_mac_header(), we can attempt
> to remove our reliance on skb_mac_header in TX paths.
> 
> When this effort completes we will remove skb_reset_mac_header()
> from __dev_queue_xmit() and replace it by
> skb_unset_mac_header() on DEBUG_NET builds.
> 
> Eric Dumazet (3):
>   net: do not use skb_mac_header() in qdisc_pkt_len_init()
>   sch_cake: do not use skb_mac_header() in cake_overhead()
>   net/sched: remove two skb_mac_header() uses
> 
>  net/core/dev.c         | 8 ++++----
>  net/sched/act_mirred.c | 2 +-
>  net/sched/act_mpls.c   | 2 +-
>  net/sched/sch_cake.c   | 6 +++---
>  4 files changed, 9 insertions(+), 9 deletions(-)
> 
> -- 
> 2.40.0.rc2.332.ga46443480c-goog
> 

skb_mac_header() shows quite a few hits in net/dsa/ as well, in functions
that contain "xmit" in the name. Should those be changed as well?