netdev - Re: [PATCH] net: atheros: atl1c: remove unused atl1c_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Mar 2023 10:20:58 +0530
From:   Pavan Chebbi <pavan.chebbi@...adcom.com>
To:     Tom Rix <trix@...hat.com>
Cc:     chris.snook@...il.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, nathan@...nel.org,
        ndesaulniers@...gle.com, yuanjilin@...rlc.com,
        liew.s.piaw@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] net: atheros: atl1c: remove unused atl1c_irq_reset function

On Tue, Mar 21, 2023 at 4:54 AM Tom Rix <trix@...hat.com> wrote:
>
> clang with W=1 reports
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c:214:20: error:
>   unused function 'atl1c_irq_reset' [-Werror,-Wunused-function]
> static inline void atl1c_irq_reset(struct atl1c_adapter *adapter)
>                    ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 10 ----------
>  1 file changed, 10 deletions(-)

Looks good to me.
Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>

>
> diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> index 40c781695d58..4a288799633f 100644
> --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> @@ -207,16 +207,6 @@ static inline void atl1c_irq_disable(struct atl1c_adapter *adapter)
>         synchronize_irq(adapter->pdev->irq);
>  }
>
> -/**
> - * atl1c_irq_reset - reset interrupt confiure on the NIC
> - * @adapter: board private structure
> - */
> -static inline void atl1c_irq_reset(struct atl1c_adapter *adapter)
> -{
> -       atomic_set(&adapter->irq_sem, 1);
> -       atl1c_irq_enable(adapter);
> -}
> -
>  /*
>   * atl1c_wait_until_idle - wait up to AT_HW_MAX_IDLE_DELAY reads
>   * of the idle status register until the device is actually idle
> --
> 2.27.0
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)