netdev - Re: [net-next 02/14] lib: cpu_rmap: Use allocator for rmap entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d58cfd92-7c94-408e-bcb5-e2a9947f8f35@nvidia.com>
Date:   Wed, 22 Mar 2023 12:01:29 +0200
From:   Eli Cohen <elic@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>, Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>
Subject: Re: [net-next 02/14] lib: cpu_rmap: Use allocator for rmap entries


On 22/03/2023 5:50, Jakub Kicinski wrote:
> On Tue, 21 Mar 2023 20:40:28 -0700 Jakub Kicinski wrote:
>>> @@ -295,7 +307,11 @@ int irq_cpu_rmap_add(struct cpu_rmap *rmap, int irq)
>>>   	glue->notify.release = irq_cpu_rmap_release;
>>>   	glue->rmap = rmap;
>>>   	cpu_rmap_get(rmap);
>>> -	glue->index = cpu_rmap_add(rmap, glue);
>>> +	rc = cpu_rmap_add(rmap, glue);
>>> +	if (rc == -1)
>>> +		return -ENOSPC;
>> which you then have to convert into an errno ?
>>
>> Also you leak glue here.
> .. and the reference on rmap.
Will fix