[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7755c026ea1f2c5f6d00aa4ba17233eb511ce3dd.camel@redhat.com>
Date: Wed, 22 Mar 2023 12:40:44 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Faicker Mo <faicker.mo@...oud.cn>
Cc: Sridhar Samudrala <sridhar.samudrala@...el.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/net_failover: fix queue exceeding warning
On Tue, 2023-03-21 at 10:29 +0800, Faicker Mo wrote:
> If the primary device queue number is bigger than the default 16,
> there is a warning about the queue exceeding when tx from the
> net_failover device.
>
> Signed-off-by: Faicker Mo <faicker.mo@...oud.cn>
This looks like a fixes, so it should include at least a fixes tag.
More importantly a longer/clearer description of the issue is needed,
including the warning backtrace.
I think this warning:
https://elixir.bootlin.com/linux/latest/source/include/linux/netdevice.h#L3542
should not be ignored/silenced: it's telling that the running
configuration is not using a number of the available tx queues, which
is possibly not the thing you want.
Instead the failover device could use an higher number of tx queues and
eventually set real_num_tx_queues equal to the primary_dev when the
latter is enslaved.
Thanks,
Paolo
Powered by blists - more mailing lists