[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <m2bkklj9t2.fsf@gmail.com>
Date: Wed, 22 Mar 2023 11:38:01 +0000
From: Donald Hunter <donald.hunter@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>, donald.hunter@...hat.com
Subject: Re: [PATCH net-next v2 2/6] tools: ynl: Add struct parsing to nlspec
Jakub Kicinski <kuba@...nel.org> writes:
> On Sun, 19 Mar 2023 19:37:59 +0000 Donald Hunter wrote:
>> +class SpecStructMember(SpecElement):
>> + """Struct member attribute
>> +
>> + Represents a single struct member attribute.
>> +
>> + Attributes:
>> + type string, kernel type of the member attribute
>
> We can have structs inside structs in theory, or "binary blobs" so this
> is really a subset of what attr can be rather than necessarily a kernel
> type?
Okay, so the schema currently defines the member types as u*, s* and
string. Does it make sense to add 'binary' and 'struct'?
To be clear, do you want me to drop the word 'kernel' from the
docstring, or something more?
>> + """
>> + def __init__(self, family, yaml):
>> + super().__init__(family, yaml)
>> + self.type = yaml['type']
>> +
>
> nit: double new line
Ack.
Powered by blists - more mailing lists