netdev - Re: [PATCH net-next v2 5/6] tools: ynl: Add fixed-header support to ynl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2355xj90v.fsf@gmail.com>
Date:   Wed, 22 Mar 2023 11:54:56 +0000
From:   Donald Hunter <donald.hunter@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, donald.hunter@...hat.com
Subject: Re: [PATCH net-next v2 5/6] tools: ynl: Add fixed-header support to
 ynl

Jakub Kicinski <kuba@...nel.org> writes:

> On Sun, 19 Mar 2023 19:38:02 +0000 Donald Hunter wrote:
>>
>>      def _dictify_ops_directional(self):
>> +        default_fixed_header = self.yaml['operations'].get('fixed-header')
>>          req_val = rsp_val = 1
>>          for elem in self.yaml['operations']['list']:
>>              if 'notify' in elem:
>> @@ -426,7 +430,7 @@ class SpecFamily(SpecElement):
>>              else:
>>                  raise Exception("Can't parse directional ops")
>>  
>> -            op = self.new_operation(elem, req_val, rsp_val)
>> +            op = self.new_operation(elem, req_val, rsp_val, default_fixed_header)
>
> Can we record the "family-default" fixed header in the family and read
> from there rather than passing the arg around?

Yes, will do.

> Also - doc - to be clear - by documentation I mean in the right places
> under Documentation/user-api/netlink/

Ack.