netdev - Re: [next-20230317][PPC/MLX5][bisected 4d5ab0a] Boot WARNING: CPU: 0 PID: 9 at net/core/dev.c:1928 call_netdevice_notifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Mar 2023 23:24:18 +0530
From:   Abdul Haleem <abdhalee@...ux.vnet.ibm.com>
To:     Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     linux-next <linux-next@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        Brian King <brking@...ux.vnet.ibm.com>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [next-20230317][PPC/MLX5][bisected 4d5ab0a] Boot WARNING: CPU: 0
 PID: 9 at net/core/dev.c:1928 call_netdevice_notifiers_info



On 3/20/23 6:55 PM, Lorenzo Bianconi wrote:
>> Greeting's
>>
>> Warning is seen while booting kernels from 6.3.0-rc3-next-20230317 on my
>> powerpc Power 10 LPAR
>>
>> Boots fine without warnings when below patch is reverted
>>
>> commit 4d5ab0ad964df178beba031b89429a601893ff61
>> Author: Lorenzo Bianconi <lorenzo@...nel.org>
>> Date:   Thu Mar 9 13:25:31 2023 +0100
>>
>>      net/mlx5e: take into account device reconfiguration for xdp_features
>> flag
>>
>>      Take into account LRO and GRO configuration setting device xdp_features
>>      flag. Consider channel rq_wq_type enabling rx scatter-gatter support in
>>      xdp_features flag and disable NETDEV_XDP_ACT_NDO_XMIT_SG since it is not
>>      supported yet by the driver.
>>      Moreover always enable NETDEV_XDP_ACT_NDO_XMIT as the ndo_xdp_xmit
>>
>> 4d5ab0ad got introduced in next-20230314
>>
>> @Lorenzo Could you please look into this
> 
> I would say this issue has been already fixed by Jakub here:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/net/core/xdp.c?id=769639c1fe8a98129aa97c8ee981639db1e8955c


Thanks Lorenzo,

Verified the patch and it fixes the problem and next-20230321 kernel 
boots fine on my powerpc lpar

Tested-by: Abdul Haleem <abdhalee@...ux.vnet.ibm.com>
-- 
Regard's

Abdul Haleem
IBM Linux Technology Center