netdev - Re: [PATCH net] sfc: ef10: don't overwrite offload features at NIC reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230322112349.0e834126@kernel.org>
Date:   Wed, 22 Mar 2023 11:23:49 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Íñigo Huguet <ihuguet@...hat.com>
Cc:     Edward Cree <ecree.xilinx@...il.com>, habetsm.xilinx@...il.com,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org, Tianhao Zhao <tizhao@...hat.com>,
        Jonathan Cooper <jonathan.s.cooper@....com>
Subject: Re: [PATCH net] sfc: ef10: don't overwrite offload features at NIC
 reset

On Wed, 22 Mar 2023 07:47:42 +0100 Íñigo Huguet wrote:
> > Could you clarify what checks were removed?  All I can see is the
> >  'NETIF_F_TSO6 requires NETIF_F_IPV6_CSUM' check, and Siena already
> >  supported NETIF_F_IPV6_CSUM (it's only Falcon that didn't).
> > Or are you also referring to some items moving from efx.c to the
> >  definition of EF10_OFFLOAD_FEATURES?  That's fine and matches more
> >  closely to what we do for ef100, but again the commit message could
> >  explain this better.
> > In any case this should really be two separate patches, with the
> >  cleanup part going to net-next.
> > That said, the above is all nit-picky, and the fix looks good, so:
> > Acked-by: Edward Cree <ecree.xilinx@...il.com>
> 
> Hi. Kindly asking about the state of this patch, it is acked since 2
> weeks ago and it appears in patchwork as "changes requested". Is there
> something else I need to do? Thanks!

The commit message needs to be beefed up to answer all questions Ed had.