netdev - Re: [PATCH bpf V2] xdp: bpf_xdp_metadata use EOPNOTSUPP for no driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Mar 2023 11:34:21 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Tariq Toukan <ttoukan.linux@...il.com>,
        Konstantin Ryabitsev <konstantin@...uxfoundation.org>
Cc:     Jesper Dangaard Brouer <brouer@...hat.com>,
        bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Martin KaFai Lau <martin.lau@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexander Lobakin <alexandr.lobakin@...el.com>,
        Larysa Zaremba <larysa.zaremba@...el.com>,
        xdp-hints@...-project.net, anthony.l.nguyen@...el.com,
        "Song, Yoong Siang" <yoong.siang.song@...el.com>,
        "Ong, Boon Leong" <boon.leong.ong@...el.com>,
        intel-wired-lan <intel-wired-lan@...ts.osuosl.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        John Fastabend <john.fastabend@...il.com>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH bpf V2] xdp: bpf_xdp_metadata use EOPNOTSUPP for no driver support

On Tue, Mar 21, 2023 at 1:43 PM Tariq Toukan <ttoukan.linux@...il.com> wrote:
>
>
>
> On 21/03/2023 15:52, Jesper Dangaard Brouer wrote:
> > When driver doesn't implement a bpf_xdp_metadata kfunc the fallback
> > implementation returns EOPNOTSUPP, which indicate device driver doesn't
> > implement this kfunc.
> >
> > Currently many drivers also return EOPNOTSUPP when the hint isn't
> > available, which is ambiguous from an API point of view. Instead
> > change drivers to return ENODATA in these cases.
> >
> > There can be natural cases why a driver doesn't provide any hardware
> > info for a specific hint, even on a frame to frame basis (e.g. PTP).
> > Lets keep these cases as separate return codes.
> >
> > When describing the return values, adjust the function kernel-doc layout
> > to get proper rendering for the return values.
> >
> > Fixes: ab46182d0dcb ("net/mlx4_en: Support RX XDP metadata")
> > Fixes: bc8d405b1ba9 ("net/mlx5e: Support RX XDP metadata")
> > Fixes: 306531f0249f ("veth: Support RX XDP metadata")
> > Fixes: 3d76a4d3d4e5 ("bpf: XDP metadata RX kfuncs")
> > Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
>
> For the mlx4/5 parts:
> Acked-by: Tariq Toukan <tariqt@...dia.com>

FYI this patch was applied to bpf tree.

pw-bot doesn't notice bpf tree anymore :(