netdev - Re: [net-next 03/14] lib: cpu_rmap: Add irq_cpu_rmap_remove to complement irq_cpu_rmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230322114556.7cc6536c@kernel.org>
Date:   Wed, 22 Mar 2023 11:45:56 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Eli Cohen <elic@...dia.com>
Cc:     Saeed Mahameed <saeed@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>
Subject: Re: [net-next 03/14] lib: cpu_rmap: Add irq_cpu_rmap_remove to
 complement irq_cpu_rmap_add

On Wed, 22 Mar 2023 13:24:33 +0200 Eli Cohen wrote:
> On 22/03/2023 5:46, Jakub Kicinski wrote:
> > On Mon, 20 Mar 2023 10:51:33 -0700 Saeed Mahameed wrote:  
> >> From: Eli Cohen <elic@...dia.com>
> >>
> >> Add a function to complement irq_cpu_rmap_add(). It removes the irq from
> >> the reverse mapping by setting the notifier to NULL.  
> > Poor commit message. You should mention that glue is released and
> > cleared via the kref.  
> 
> Why is it necessary to mention glue which is internal to the 
> implementation and is not part of the API?

So that the reviewer of the code knows and knows that you know.

> > BTW who can hold the kref? What are the chances that user will call:  
> 
> The glue kref is used to ensure the glue is not remove when the callback 
> is called in the workqueue context.
> 
> Re chances, not really high since a driver usually deals with rmap at 
> load and unload time.

Mention it in the commit message please, to make sure Thomas is aware
when he acks.