lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAKH8qBtmpr_44kq9dOr4Kdz8t9xNFp4ow6J0_6EEyJhNgA=sTg@mail.gmail.com> Date: Wed, 22 Mar 2023 12:00:40 -0700 From: Stanislav Fomichev <sdf@...gle.com> To: Alexei Starovoitov <alexei.starovoitov@...il.com> Cc: Jesper Dangaard Brouer <brouer@...hat.com>, bpf <bpf@...r.kernel.org>, Network Development <netdev@...r.kernel.org>, Martin KaFai Lau <martin.lau@...nel.org>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Alexander Lobakin <alexandr.lobakin@...el.com>, Larysa Zaremba <larysa.zaremba@...el.com>, xdp-hints@...-project.net, anthony.l.nguyen@...el.com, "Song, Yoong Siang" <yoong.siang.song@...el.com>, "Ong, Boon Leong" <boon.leong.ong@...el.com>, intel-wired-lan <intel-wired-lan@...ts.osuosl.org>, Paolo Abeni <pabeni@...hat.com>, Jesse Brandeburg <jesse.brandeburg@...el.com>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, John Fastabend <john.fastabend@...il.com>, Jesper Dangaard Brouer <hawk@...nel.org>, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH bpf-next V3 3/6] selftests/bpf: xdp_hw_metadata RX hash return code info On Wed, Mar 22, 2023 at 9:09 AM Alexei Starovoitov <alexei.starovoitov@...il.com> wrote: > > On Wed, Mar 22, 2023 at 9:01 AM Jesper Dangaard Brouer > <brouer@...hat.com> wrote: > > > > When driver developers add XDP-hints kfuncs for RX hash it is > > practical to print the return code in bpf_printk trace pipe log. > > > > Print hash value as a hex value, both AF_XDP userspace and bpf_prog, > > as this makes it easier to spot poor quality hashes. > > > > Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com> > > Acked-by: Stanislav Fomichev <sdf@...gle.com> > > --- > > .../testing/selftests/bpf/progs/xdp_hw_metadata.c | 9 ++++++--- > > tools/testing/selftests/bpf/xdp_hw_metadata.c | 5 ++++- > > 2 files changed, 10 insertions(+), 4 deletions(-) > > > > diff --git a/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c b/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c > > index 40c17adbf483..ce07010e4d48 100644 > > --- a/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c > > +++ b/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c > > @@ -77,10 +77,13 @@ int rx(struct xdp_md *ctx) > > meta->rx_timestamp = 0; /* Used by AF_XDP as not avail signal */ > > } > > > > - if (!bpf_xdp_metadata_rx_hash(ctx, &meta->rx_hash)) > > - bpf_printk("populated rx_hash with %u", meta->rx_hash); > > - else > > + ret = bpf_xdp_metadata_rx_hash(ctx, &meta->rx_hash); > > + if (ret >= 0) { > > + bpf_printk("populated rx_hash with 0x%08X", meta->rx_hash); > > + } else { > > + bpf_printk("rx_hash not-avail errno:%d", ret); > > meta->rx_hash = 0; /* Used by AF_XDP as not avail signal */ > > + } > > Just noticed this mess of printks. > Please remove them all. selftests should not have them. See my reply in the v2.
Powered by blists - more mailing lists