netdev - Re: [PATCH net-next 1/2] net: ethernet: mtk_eth_soc: add code for offloading flows from wlan devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBtfo1q3E8u1bwD/@corigine.com>
Date:   Wed, 22 Mar 2023 21:05:55 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Felix Fietkau <nbd@....name>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net: ethernet: mtk_eth_soc: add code for
 offloading flows from wlan devices

On Wed, Mar 22, 2023 at 04:19:41PM +0100, Felix Fietkau wrote:
> On 22.03.23 15:29, Simon Horman wrote:
> > On Wed, Mar 22, 2023 at 03:04:19PM +0100, Simon Horman wrote:
> > > On Tue, Mar 21, 2023 at 02:36:08PM +0100, Felix Fietkau wrote:
> > > > WED version 2 (on MT7986 and later) can offload flows originating from wireless
> > > > devices. In order to make that work, ndo_setup_tc needs to be implemented on
> > > > the netdevs. This adds the required code to offload flows coming in from WED,
> > > > while keeping track of the incoming wed index used for selecting the correct
> > > > PPE device.
> > > >
> > > > Signed-off-by: Felix Fietkau <nbd@....name>
> > > 
> > > Hi Felix,
> > > 
> > > A few nits from my side.
> > > 
> > > First, please reformat the patch description to have a maximum of 75 characters
> > > per line, as suggested by checkpatch.
> > > 
> > > ...
> > 
> > One more.
> > 
> > This seems to conflict with:
> > 
> >    [PATCH net 1/2] net: ethernet: mtk_eth_soc: fix flow block
> > 
> > So I guess this series needs to be rebased on that one one at some point.
> I don't think this conflicts. My local rebase tests didn't show any issues
> either.

Ok, sorry for the noise there.
I must have messed something up when I checked earlier.