netdev - Re: [PATCH net-next v2 2/6] tools: ynl: Add struct parsing to nlspec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230321222245.48328d8b@kernel.org>
Date:   Tue, 21 Mar 2023 22:22:45 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Donald Hunter <donald.hunter@...il.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, donald.hunter@...hat.com
Subject: Re: [PATCH net-next v2 2/6] tools: ynl: Add struct parsing to
 nlspec

On Sun, 19 Mar 2023 19:37:59 +0000 Donald Hunter wrote:
> +class SpecStructMember(SpecElement):
> +    """Struct member attribute
> +
> +    Represents a single struct member attribute.
> +
> +    Attributes:
> +        type    string, kernel type of the member attribute

We can have structs inside structs in theory, or "binary blobs" so this
is really a subset of what attr can be rather than necessarily a kernel
type?

> +    """
> +    def __init__(self, family, yaml):
> +        super().__init__(family, yaml)
> +        self.type = yaml['type']
> +

nit: double new line

> +class SpecStruct(SpecElement):
> +    """Netlink struct type