netdev - Re: [PATCH net-next v4] vxlan: try to send a packet normally if local bypass fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBq7yv0W5MqhqYnm@shredder>
Date:   Wed, 22 Mar 2023 10:26:50 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     Vladimir Nikishkin <vladimir@...ishkin.pw>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com,
        eng.alaamohamedsoliman.am@...il.com, gnault@...hat.com,
        razor@...ckwall.org
Subject: Re: [PATCH net-next v4] vxlan: try to send a packet normally if
 local bypass fails

On Wed, Mar 22, 2023 at 03:04:14PM +0800, Vladimir Nikishkin wrote:
> --- a/Documentation/networking/vxlan.rst
> +++ b/Documentation/networking/vxlan.rst
> @@ -86,3 +86,16 @@ offloaded ports can be interrogated with `ethtool`::
>        Types: geneve, vxlan-gpe
>        Entries (1):
>            port 1230, vxlan-gpe
> +
> +=================
> +Sysctls
> +=================
> +
> +One sysctl influences the behaviour of the vxlan driver.
> +
> + - `vxlan.disable_local_bypass`
> +
> +If set to 1, and if there is a packet destined to the local address, for which the
> +driver cannot find a corresponding vni, it is forwarded to the userspace networking
> +stack. This is useful if there is some userspace UDP tunnel waiting for such
> +packets.

Hi,

I don't believe sysctl is the right interface for this. VXLAN options
are usually / always added as netlink attributes. See ip-link man page
under "VXLAN Type Support".

Also, please add a selftest under tools/testing/selftests/net/. We
already have a bunch of VXLAN tests that you can use as a reference.

Thanks