netdev - RE: [PATCH net] tools: ynl: add the Python requirements.txt file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN6PR11MB4177900926AF2BDDB3F6A7DEE3879@BN6PR11MB4177.namprd11.prod.outlook.com>
Date:   Thu, 23 Mar 2023 10:33:42 +0000
From:   "Michalik, Michal" <michal.michalik@...el.com>
To:     Edward Cree <ecree.xilinx@...il.com>,
        Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>
Subject: RE: [PATCH net] tools: ynl: add the Python requirements.txt file

On 21 March 2023 7:52 PM CET, Edward Cree wrote:
> 
> On 21/03/2023 17:52, Jakub Kicinski wrote:
>> Given the "system script" nature of the project (vs "full application")
>> I don't find the requirements to be necessary right now.
> 
> I'd say it's good to document the dependencies, because otherwise
>  getting it to run could be a PITA for the user; poking around I
>  don't see a convenient readme that could have a note added like
>  "This tool requires the PyYAML and jsonschema libraries".
> And if you're going to add a document just for this then it *may
>  as well* be in the machine-readable format that pip install can
>  consume.
> 

Thanks - I will prepare the new version which implements your suggestions
to be less specific about packages versions and remove it's dependencies.

>> But I don't know much about Python, so maybe Ed can make a call? :D
> 
> I'm not exactly an expert either :D

Still I learned useful things - really appreciate that!

BR,
M^2