netdev - Re: [PATCH net-next v2 2/4] selftests: tc-testing: extend the "skip" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6ed0c28-248c-e383-cf05-a8a9bec73b20@mojatatu.com>
Date:   Thu, 23 Mar 2023 11:01:53 -0300
From:   Pedro Tammela <pctammela@...atatu.com>
To:     Davide Caratti <dcaratti@...hat.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Ilya Maximets <i.maximets@....org>
Cc:     Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/4] selftests: tc-testing: extend the "skip"
 property

On 23/03/2023 10:34, Davide Caratti wrote:
> currently, users can skip individual test cases by means of writing
> 
>    "skip": "yes"
> 
> in the scenario file. Extend this functionality by allowing the execution
> of a command, written in the "skip" property for a specific test case. If
> such property is present, tdc executes that command and skips the test if
> the return value is non-zero.
> 
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>


I saw the use case in patch 3 but I didn't understand how it can happen.
Shouldn't iproute2 at least match the kernel version? I know it's not a 
hard requirement for 99% of use cases, but when running tdc I would 
argue it's the minimum expected.