netdev - Re: [PATCH v2] Bluetooth: msft: Extended monitor tracking by address filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBxiqB7uboVw23Jl@corigine.com>
Date:   Thu, 23 Mar 2023 15:31:04 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     hildawu@...ltek.com
Cc:     marcel@...tmann.org, johan.hedberg@...il.com, luiz.dentz@...il.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, linux-bluetooth@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        apusaka@...omium.org, mmandlik@...gle.com, yinghsu@...omium.org,
        max.chou@...ltek.com, alex_lu@...lsil.com.cn, kidman@...ltek.com
Subject: Re: [PATCH v2] Bluetooth: msft: Extended monitor tracking by address
 filter

On Wed, Mar 22, 2023 at 03:27:12PM +0800, hildawu@...ltek.com wrote:
> From: Hilda Wu <hildawu@...ltek.com>
> 
> Since limited tracking device per condition, this feature is to support
> tracking multiple devices concurrently.
> When a pattern monitor detects the device, this feature issues an address
> monitor for tracking that device. Let pattern monitor can keep monitor
> new devices.
> This feature adds an address filter when receiving a LE monitor device
> event which monitor handle is for a pattern, and the controller started
> monitoring the device. And this feature also has cancelled the monitor
> advertisement from address filters when receiving a LE monitor device
> event when the controller stopped monitoring the device specified by an
> address and monitor handle.
> 
> Signed-off-by: Alex Lu <alex_lu@...lsil.com.cn>
> Signed-off-by: Hilda Wu <hildawu@...ltek.com>
> ---
> Changes in v2:
> - Fixed build bot warning, removed un-used parameter.
> - Follow suggested, adjust for readability and idiomatic, modified
>   error case, etc.

Thanks for addressing my review.

If you do need to spin a v3, then you might want to consider using
reverse xmas tree universally for local variable declarations
in your new code.

But that notwithstanding, from a code-style sanity check pov:

Reviewed-by: Simon Horman <simon.horman@...igine.com>