netdev - Re: [PATCH v2 net] sfc: ef10: don't overwrite offload features at NIC reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa91d648-9293-795b-2e42-d4373081d538@gmail.com>
Date:   Thu, 23 Mar 2023 15:16:47 +0000
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Íñigo Huguet <ihuguet@...hat.com>,
        habetsm.xilinx@...il.com
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        Tianhao Zhao <tizhao@...hat.com>,
        Jonathan Cooper <jonathan.s.cooper@....com>
Subject: Re: [PATCH v2 net] sfc: ef10: don't overwrite offload features at NIC
 reset

On 23/03/2023 08:34, Íñigo Huguet wrote:
> At NIC reset, some offload features related to encapsulated traffic
> might have changed (this mainly happens if the firmware-variant is
> changed with the sfboot userspace tool). Because of this, features are
> checked and set again at reset time.
> 
> However, this was not done right, and some features were improperly
> overwritten at NIC reset:
> - Tunneled IPv6 segmentation was always disabled
> - Features disabled with ethtool were reenabled
> - Features that becomes unsupported after the reset were not disabled
> 
> Also, checking if the device supports IPV6_CSUM to enable TSO6 is no
> longer necessary because all currently supported devices support it.
> Additionally, move the assignment of some other features to the
> EF10_OFFLOAD_FEATURES macro, like it is done in ef100, leaving the
> selection of features in efx_pci_probe_post_io a bit cleaner.
> 
> Fixes: ffffd2454a7a ("sfc: correctly advertise tunneled IPv6 segmentation")
> Fixes: 24b2c3751aa3 ("sfc: advertise encapsulated offloads on EF10")
> Reported-by: Tianhao Zhao <tizhao@...hat.com>
> Suggested-by: Jonathan Cooper <jonathan.s.cooper@....com>
> Tested-by: Jonathan Cooper <jonathan.s.cooper@....com>
> Signed-off-by: Íñigo Huguet <ihuguet@...hat.com>
> ---
> v2: reworded the paragraph that explains the code cleanup in efx_pci_probe_post_io
> because it was not very clear
> ---

Acked-by: Edward Cree <ecree.xilinx@...il.com>