netdev - Re: [PATCH v7 net-next 1/7] netlink: Add a macro to set policy message with format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230323102906.3fb3d658@kernel.org>
Date:   Thu, 23 Mar 2023 10:29:06 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Shay Agroskin <shayagr@...zon.com>
Cc:     David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>,
        "Woodhouse, David" <dwmw@...zon.com>,
        "Machulsky, Zorik" <zorik@...zon.com>,
        "Matushevsky, Alexander" <matua@...zon.com>,
        Saeed Bshara <saeedb@...zon.com>,
        "Wilson, Matt" <msw@...zon.com>,
        "Liguori, Anthony" <aliguori@...zon.com>,
        "Bshara, Nafea" <nafea@...zon.com>,
        "Belgazal, Netanel" <netanel@...zon.com>,
        "Saidi, Ali" <alisaidi@...zon.com>,
        "Herrenschmidt, Benjamin" <benh@...zon.com>,
        "Kiyanovski, Arthur" <akiyano@...zon.com>,
        "Dagan, Noam" <ndagan@...zon.com>,
        "Arinzon, David" <darinzon@...zon.com>,
        "Itzko, Shahar" <itzko@...zon.com>,
        "Abboud, Osama" <osamaabb@...zon.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Andrew Lunn <andrew@...n.ch>,
        Guangbin Huang <huangguangbin2@...wei.com>,
        "Jie Wang" <wangjie125@...wei.com>,
        Johannes Berg <johannes@...solutions.net>,
        Edward Cree <ecree.xilinx@...il.com>,
        Florian Westphal <fw@...len.de>
Subject: Re: [PATCH v7 net-next 1/7] netlink: Add a macro to set policy
 message with format string

On Thu, 23 Mar 2023 18:36:04 +0200 Shay Agroskin wrote:
> +#define NL_SET_ERR_MSG_ATTR_POL_FMT(extack, attr, pol, fmt, args...) do {	\
> +	struct netlink_ext_ack *__extack = (extack);				\
> +										\
> +	if (!__extack)								\
> +		break;								\
> +										\
> +	if (snprintf(__extack->_msg_buf, NETLINK_MAX_FMTMSG_LEN,		\
> +		     "%s" fmt "%s", "", ##args, "") >=				\
> +	    NETLINK_MAX_FMTMSG_LEN)						\
> +		net_warn_ratelimited("%s" fmt "%s", "truncated extack: ",       \
> +				     ##args, "\n");				\
> +										\
> +	do_trace_netlink_extack(__extack->_msg_buf);				\
> +										\
> +	__extack->_msg = __extack->_msg_buf;					\
> +	__extack->bad_attr = (attr);						\
> +	__extack->policy = (pol);						\
> +} while (0)

Given the misunderstanding let me give you an exception to the 24h 
wait period. Feel free to send v8 when ready, I'll drop this version 
from pw.