netdev - Re: [PATCH net-next 2/4] net/mlx5: Implement devlink port function cmds to control ipsec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202303240548.WDzL68Ny-lkp@intel.com>
Date:   Fri, 24 Mar 2023 05:49:00 +0800
From:   kernel test robot <lkp@...el.com>
To:     Dima Chumak <dchumak@...dia.com>, Jakub Kicinski <kuba@...nel.org>
Cc:     oe-kbuild-all@...ts.linux.dev, Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, Jiri Pirko <jiri@...nulli.us>,
        Leon Romanovsky <leon@...nel.org>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Dima Chumak <dchumak@...dia.com>
Subject: Re: [PATCH net-next 2/4] net/mlx5: Implement devlink port function
 cmds to control ipsec_crypto

Hi Dima,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20230323]
[cannot apply to net-next/main net/main horms-ipvs/master linus/master v6.3-rc3 v6.3-rc2 v6.3-rc1 v6.3-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dima-Chumak/devlink-Expose-port-function-commands-to-control-IPsec-crypto-offloads/20230323-191353
patch link:    https://lore.kernel.org/r/20230323111059.210634-3-dchumak%40nvidia.com
patch subject: [PATCH net-next 2/4] net/mlx5: Implement devlink port function cmds to control ipsec_crypto
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20230324/202303240548.WDzL68Ny-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/ca580efef4996834c003bf5e8d6d244fe0550415
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Dima-Chumak/devlink-Expose-port-function-commands-to-control-IPsec-crypto-offloads/20230323-191353
        git checkout ca580efef4996834c003bf5e8d6d244fe0550415
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/net/ethernet/mellanox/mlx5/core/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303240548.WDzL68Ny-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c: In function 'mlx5_devlink_port_fn_ipsec_crypto_set':
>> drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:4203:24: error: 'struct net' has no member named 'xfrm'
    4203 |         mutex_lock(&net->xfrm.xfrm_cfg_mutex);
         |                        ^~
   drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:4239:26: error: 'struct net' has no member named 'xfrm'
    4239 |         mutex_unlock(&net->xfrm.xfrm_cfg_mutex);
         |                          ^~


vim +4203 drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c

  4173	
  4174	int mlx5_devlink_port_fn_ipsec_crypto_set(struct devlink_port *port, bool enable,
  4175						  struct netlink_ext_ack *extack)
  4176	{
  4177		struct mlx5_eswitch *esw;
  4178		struct mlx5_vport *vport;
  4179		int err = -EOPNOTSUPP;
  4180		struct net *net;
  4181	
  4182		esw = mlx5_devlink_eswitch_get(port->devlink);
  4183		if (IS_ERR(esw))
  4184			return PTR_ERR(esw);
  4185	
  4186		if (!mlx5_esw_ipsec_vf_offload_supported(esw->dev)) {
  4187			NL_SET_ERR_MSG_MOD(extack, "Device doesn't support ipsec_crypto");
  4188			return err;
  4189		}
  4190	
  4191		vport = mlx5_devlink_port_fn_get_vport(port, esw);
  4192		if (IS_ERR(vport)) {
  4193			NL_SET_ERR_MSG_MOD(extack, "Invalid port");
  4194			return PTR_ERR(vport);
  4195		}
  4196	
  4197		/* xfrm_cfg lock is needed to avoid races with XFRM state being added to
  4198		 * the PF net device. Netlink stack takes this lock for `ip xfrm` user
  4199		 * commands, so here we need to take it before esw->state_lock to
  4200		 * preserve the order.
  4201		 */
  4202		net = dev_net(esw->dev->mlx5e_res.uplink_netdev);
> 4203		mutex_lock(&net->xfrm.xfrm_cfg_mutex);

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests