netdev - Re: [PATCH 2/2] net/mlx5e: Fix missing error code in mlx5e_rx_reporter_err_icosq_cqe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CRELVC6KO8JZ.1NE68362NERXX@den-dk-m31857>
Date:   Fri, 24 Mar 2023 12:17:42 +0000
From:   <Steen.Hegelund@...rochip.com>
To:     <jiapeng.chong@...ux.alibaba.com>, <saeedm@...dia.com>
CC:     <leon@...nel.org>, <davem@...emloft.net>, <edumazet@...gle.com>,
        <kuba@...nel.org>, <pabeni@...hat.com>, <richardcochran@...il.com>,
        <netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <abaci@...ux.alibaba.com>
Subject: Re: [PATCH 2/2] net/mlx5e: Fix missing error code in
 mlx5e_rx_reporter_err_icosq_cqe_recover()

Hi Jiapeng,

This looks good too.

On Fri Mar 24, 2023 at 3:55 AM CET, Jiapeng Chong wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'err'.
>
> drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c:105 mlx5e_tx_reporter_err_cqe_recover() warn: missing error code 'err'.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4600
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c
> index 44c1926843a1..5e2e2449668d 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c
> @@ -101,8 +101,10 @@ static int mlx5e_tx_reporter_err_cqe_recover(void *ctx)
>                 goto out;
>         }
>
> -       if (state != MLX5_SQC_STATE_ERR)
> +       if (state != MLX5_SQC_STATE_ERR) {
> +               err = -EINVAL;
>                 goto out;
> +       }
>
>         mlx5e_tx_disable_queue(sq->txq);
>
> --
> 2.20.1.7.g153144c


Reviewed-by: Steen Hegelund <Steen.Hegelund@...rochip.com>

BR
Steen