[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4a19d213-7687-c9bf-739a-a2b783aa3e87@gmail.com>
Date: Fri, 24 Mar 2023 18:37:13 +0000
From: Edward Cree <ecree.xilinx@...il.com>
To: edward.cree@....com, linux-net-drivers@....com,
davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
netdev@...r.kernel.org, michal.swiatkowski@...ux.intel.com,
Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next v2 5/6] sfc: add code to register and unregister
encap matches
On 24/03/2023 09:10, Martin Habets wrote:
> On Thu, Mar 23, 2023 at 10:05:30PM -0700, Jakub Kicinski wrote:
>> clang sayeth
>>
>> drivers/net/ethernet/sfc/tc.c:414:43: warning: variable 'ipv6' is uninitialized when used here [-Wuninitialized]
>> rc = efx_mae_check_encap_match_caps(efx, ipv6, extack);
>
> If CONFIG_IPV6 is unset it is never used, to is needs a __maybe_unused
> as well.
efx_mae_check_encap_match_caps() uses it regardless of the CONFIG,
as does the extack setting just below it.
So it just needs initialising to `false`, will fix in v3.
(No idea why gcc doesn't warn about it, not even on W=1.)
Powered by blists - more mailing lists