netdev - Re: [PATCH net-next v2] bnx2: remove deadcode in bnx2_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 24 Mar 2023 05:00:26 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Maxim Korotkov <korotkov.maxim.s@...il.com>
Cc:     rmody@...vell.com, GR-Linux-NIC-Dev@...vell.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, mchan@...adcom.com, vadim.fedorenko@...ux.dev,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        lvc-project@...uxtesting.org, leonro@...dia.com
Subject: Re: [PATCH net-next v2] bnx2: remove deadcode in bnx2_init_cpus()

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 22 Mar 2023 19:28:43 +0300 you wrote:
> The load_cpu_fw function has no error return code
> and always returns zero. Checking the value returned by
> this function does not make sense.
> Now checking the value of the return value is misleading when reading
> the code. Path with error handling was deleted in 57579f7629a3
> ("bnx2: Use request_firmware()").
> As a result, bnx2_init_cpus() will also return only zero
> Therefore, it will be safe to change the type of functions
> to void and remove checking to improving readability.
> 
> [...]

Here is the summary with links:
  - [net-next,v2] bnx2: remove deadcode in bnx2_init_cpus()
    https://git.kernel.org/netdev/net-next/c/4691720f509a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html