netdev - Re: [PATCH net-next] sh_eth: remove open coded netif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d2f216c-df1d-9ab5-353c-de5e5e082b57@omp.ru>
Date:   Sat, 25 Mar 2023 23:27:25 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Jakub Kicinski <kuba@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
CC:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        <netdev@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] sh_eth: remove open coded netif_running()

On 3/23/23 7:40 PM, Jakub Kicinski wrote:
[...]

>> Is there some protection against parallel execution of ndo_open()
>> and get_stats()?
> 
> Nope - one is under rtnl_lock, the other under just RCU, IIRC.
> So this patch just makes the race worse, but it was already
> racy before.

   How about reverting it then?

MBR, Sergey