netdev - Re: [PATCH v2] rtlwifi: fix incorrect error codes in rtl_debugfs_set_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZB/+Lhyxg7Ur3/c7@corigine.com>
Date:   Sun, 26 Mar 2023 10:11:26 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Wei Chen <harperchen1110@...il.com>
Cc:     pkshih@...ltek.com, kvalo@...nel.org, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rtlwifi: fix incorrect error codes in
 rtl_debugfs_set_write_reg()

On Sun, Mar 26, 2023 at 05:42:17AM +0000, Wei Chen wrote:
> If there is a failure during copy_from_user or user-provided data buffer is
> invalid, rtl_debugfs_set_write_reg should return negative error code instead
> of a positive value count.
> 
> Fix this bug by returning correct error code. Moreover, the check of buffer
> against null is removed since it will be handled by copy_from_user.
> 
> Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs")
> Signed-off-by: Wei Chen <harperchen1110@...il.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>