netdev - Re: [PATCH net-next v2 5/6] sfc: add code to register and unregister encap matches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 26 Mar 2023 11:18:08 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     edward.cree@....com
Cc:     linux-net-drivers@....com, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com,
        Edward Cree <ecree.xilinx@...il.com>, netdev@...r.kernel.org,
        habetsm.xilinx@...il.com, michal.swiatkowski@...ux.intel.com
Subject: Re: [PATCH net-next v2 5/6] sfc: add code to register and unregister
 encap matches

On Thu, Mar 23, 2023 at 08:45:13PM +0000, edward.cree@....com wrote:
> From: Edward Cree <ecree.xilinx@...il.com>
> 
> Add a hashtable to detect duplicate and conflicting matches.  If match
>  is not a duplicate, call MAE functions to add/remove it from OR table.
> Calling code not added yet, so mark the new functions as unused.
> 
> Signed-off-by: Edward Cree <ecree.xilinx@...il.com>
> ---
> Changed in v2: replace `unsigned char ipv` with `bool ipv6`, simplifying
>  code (suggested by Michal)

Many bits have been spilt on a minor problem around initialising 'ipv6 [1][2].
But that aside, this looks good to me.

Reviewed-by: Simon Horman <simon.horman@...igine.com>

[1] https://lore.kernel.org/all/20230323220530.0d979b62@kernel.org/
[2] https://lore.kernel.org/all/202303250154.HsaEs3hh-lkp@intel.com/