netdev - Re: [PATCH V2] can: usb: f81604: add Fintek F81604 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 26 Mar 2023 11:30:37 +0900
From:   Vincent MAILHOL <mailhol.vincent@...adoo.fr>
To:     Peter Hong <peter_hong@...tek.com.tw>
Cc:     wg@...ndegger.com, mkl@...gutronix.de,
        michal.swiatkowski@...ux.intel.com, Steen.Hegelund@...rochip.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, frank.jungclaus@....eu,
        linux-kernel@...r.kernel.org, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, hpeter+linux_kernel@...il.com
Subject: Re: [PATCH V2] can: usb: f81604: add Fintek F81604 support

On Tue. 23 Mar 2023 at 14:54, Vincent MAILHOL
<mailhol.vincent@...adoo.fr> wrote:
> Le jeu. 23 mars 2023 à 14:14, Peter Hong <peter_hong@...tek.com.tw> a écrit :

(...)

> > struct f81604_bulk_data {
> >      u8 cmd;
> >      u8 dlc;
> >
> >      union {
> >          struct {
> >              u8 id1, id2;
> >              u8 data[CAN_MAX_DLEN];
> >          } sff;
> >
> >          struct {
> >              u8 id1, id2, id3, id4;
> >              u8 data[CAN_MAX_DLEN];
> >          } eff;
> >      };
> > } __attribute__((packed));

Actually, there is an alias for this attribute. Just use __packed
instead of __attribute__((packed)).

(...)