netdev - Re: [PATCH v3 2/3] net: mvpp2: parser fix QinQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPv3WKcmQezyvUY8T1y=wRNn-w_0fMqgzU3+GoQMHRXNM_MXNA@mail.gmail.com>
Date:   Mon, 27 Mar 2023 17:48:33 +0200
From:   Marcin Wojtas <mw@...ihalf.com>
To:     Sven Auhagen <sven.auhagen@...eatech.de>
Cc:     netdev@...r.kernel.org, linux@...linux.org.uk, kuba@...nel.org,
        davem@...emloft.net, maxime.chevallier@...tlin.com,
        pabeni@...hat.com
Subject: Re: [PATCH v3 2/3] net: mvpp2: parser fix QinQ

sob., 25 mar 2023 o 17:40 Sven Auhagen <sven.auhagen@...eatech.de> napisał(a):
>
> The mvpp2 parser entry for QinQ has the inner and outer VLAN
> in the wrong order.
> Fix the problem by swapping them.
>
> Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit")
> Signed-off-by: Sven Auhagen <sven.auhagen@...eatech.de>
> ---
>
> Change from v2:
>         * Formal fixes
>
> Change from v1:
>         * Added the fixes tag
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c
> index 75ba57bd1d46..ed8be396428b 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c
> @@ -1539,8 +1539,8 @@ static int mvpp2_prs_vlan_init(struct platform_device *pdev, struct mvpp2 *priv)
>         if (!priv->prs_double_vlans)
>                 return -ENOMEM;
>
> -       /* Double VLAN: 0x8100, 0x88A8 */
> -       err = mvpp2_prs_double_vlan_add(priv, ETH_P_8021Q, ETH_P_8021AD,
> +       /* Double VLAN: 0x88A8, 0x8100 */
> +       err = mvpp2_prs_double_vlan_add(priv, ETH_P_8021AD, ETH_P_8021Q,
>                                         MVPP2_PRS_PORT_MASK);
>         if (err)
>                 return err;
> --
> 2.33.1
>

Reviewed-by: Marcin Wojtas <mw@...ihalf.com>

Thanks,
Marcin