netdev - Re: [PATCH net] vsock/loopback: use only sk_buff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Mar 2023 07:20:18 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Stefano Garzarella <sgarzare@...hat.com>
Cc:     netdev@...r.kernel.org, bobby.eshleman@...edance.com,
        davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
        linux-kernel@...r.kernel.org, avkrasnov@...rdevices.ru,
        kuba@...nel.org, virtualization@...ts.linux-foundation.org,
        syzbot+befff0a9536049e7902e@...kaller.appspotmail.com
Subject: Re: [PATCH net] vsock/loopback: use only sk_buff_head.lock to protect the
 packet queue

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@...emloft.net>:

On Fri, 24 Mar 2023 12:54:50 +0100 you wrote:
> pkt_list_lock was used before commit 71dc9ec9ac7d ("virtio/vsock:
> replace virtio_vsock_pkt with sk_buff") to protect the packet queue.
> After that commit we switched to sk_buff and we are using
> sk_buff_head.lock in almost every place to protect the packet queue
> except in vsock_loopback_work() when we call skb_queue_splice_init().
> 
> As reported by syzbot, this caused unlocked concurrent access to the
> packet queue between vsock_loopback_work() and
> vsock_loopback_cancel_pkt() since it is not holding pkt_list_lock.
> 
> [...]

Here is the summary with links:
  - [net] vsock/loopback: use only sk_buff_head.lock to protect the packet queue
    https://git.kernel.org/netdev/net/c/b465518dc27d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html