netdev - RE: [Intel-wired-lan] [PATCH net v1 2/2] ice: Fix ice_cfg_rdma_fltr() to only update relevant fields

Open Source and information security mailing list archives

Message-ID: <BN7PR11MB278865C2B8733887FBEF645BE68B9@BN7PR11MB2788.namprd11.prod.outlook.com>
Date:   Mon, 27 Mar 2023 07:36:28 +0000
From:   "Andrysiak, Jakub" <jakub.andrysiak@...el.com>
To:     "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Brett Creeley <brett.creeley@...el.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Malz, RobertX" <robertx.malz@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH net v1 2/2] ice: Fix ice_cfg_rdma_fltr()
 to only update relevant fields

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Jesse
> Brandeburg
> Sent: Monday, March 13, 2023 9:36 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Brett Creeley <brett.creeley@...el.com>;
> Brandeburg, Jesse <jesse.brandeburg@...el.com>; Malz, RobertX
> <robertx.malz@...el.com>
> Subject: [Intel-wired-lan] [PATCH net v1 2/2] ice: Fix ice_cfg_rdma_fltr() to only
> update relevant fields
> 
> From: Brett Creeley <brett.creeley@...el.com>
> 
> The current implementation causes ice_vsi_update() to update all VSI fields
> based on the cached VSI context. This also assumes that the
> ICE_AQ_VSI_PROP_Q_OPT_VALID bit is set. This can cause problems if the VSI
> context is not correctly synced by the driver. Fix this by only updating the fields
> that correspond to ICE_AQ_VSI_PROP_Q_OPT_VALID.
> Also, make sure to save the updated result in the cached VSI context on success.
> 
> Fixes: 348048e724a0 ("ice: Implement iidc operations")
> Co-developed-by: Robert Malz <robertx.malz@...el.com>
> Signed-off-by: Robert Malz <robertx.malz@...el.com>
> Signed-off-by: Brett Creeley <brett.creeley@...el.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Reviewed-by: Piotr Raczynski <piotr.raczynski@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_switch.c | 26 +++++++++++++++++----
>  1 file changed, 22 insertions(+), 4 deletions(-)
>  
Tested-by: Jakub Andrysiak <jakub.andrysiak@...el.com>
_______________________________________________
 Intel-wired-lan mailing list
 Intel-wired-lan@...osl.org
 https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives