lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230328124859.12f3c329@xps-13> Date: Tue, 28 Mar 2023 12:48:59 +0200 From: Miquel Raynal <miquel.raynal@...tlin.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> Cc: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Hauke Mehrtens <hauke@...ke-m.de>, Woojung Huh <woojung.huh@...rochip.com>, UNGLinuxDriver@...rochip.com, Claudiu Manoil <claudiu.manoil@....com>, Alexandre Belloni <alexandre.belloni@...tlin.com>, Colin Foster <colin.foster@...advantage.com>, Michael Hennerich <michael.hennerich@...log.com>, Alexander Aring <alex.aring@...il.com>, Stefan Schmidt <stefan@...enfreihafen.org>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-wpan@...r.kernel.org Subject: Re: [PATCH 07/12] net: ieee802154: adf7242: drop of_match_ptr for ID table Hi Krzysztof, krzysztof.kozlowski@...aro.org wrote on Sat, 11 Mar 2023 18:32:58 +0100: > The driver will match mostly by DT table (even thought there is regular > ID table) so there is little benefit in of_match_ptr (this also allows > ACPI matching via PRP0001, even though it might not be relevant here). > > drivers/net/ieee802154/adf7242.c:1322:34: error: ‘adf7242_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> I see Stefan already acked most of the ieee802154 patches, but I didn't got notified for this one, so in case: Acked-by: Miquel Raynal <miquel.raynal@...tlin.com> > --- > drivers/net/ieee802154/adf7242.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c > index 5cf218c674a5..509acc86001c 100644 > --- a/drivers/net/ieee802154/adf7242.c > +++ b/drivers/net/ieee802154/adf7242.c > @@ -1336,7 +1336,7 @@ MODULE_DEVICE_TABLE(spi, adf7242_device_id); > static struct spi_driver adf7242_driver = { > .id_table = adf7242_device_id, > .driver = { > - .of_match_table = of_match_ptr(adf7242_of_match), > + .of_match_table = adf7242_of_match, > .name = "adf7242", > .owner = THIS_MODULE, > }, Thanks, Miquèl
Powered by blists - more mailing lists