lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230328130046.GG15196@pengutronix.de> Date: Tue, 28 Mar 2023 15:00:46 +0200 From: Oleksij Rempel <o.rempel@...gutronix.de> To: Andrew Lunn <andrew@...n.ch> Cc: Wei Fang <wei.fang@....com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, kernel@...gutronix.de, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, Shenwei Wang <shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>, NXP Linux Team <linux-imx@....com>, Amit Cohen <amcohen@...dia.com>, Gal Pressman <gal@...dia.com>, Alexandru Tachici <alexandru.tachici@...log.com>, Piergiorgio Beruto <piergiorgio.beruto@...il.com>, Willem de Bruijn <willemb@...gle.com>, Vladimir Oltean <vladimir.oltean@....com> Subject: Re: [PATCH net-next v2 6/8] net: phy: at803x: Make SmartEEE support optional and configurable via ethtool On Tue, Mar 28, 2023 at 02:49:58PM +0200, Andrew Lunn wrote: > > > @@ -302,6 +312,8 @@ struct at803x_priv { > > > u8 smarteee_lpi_tw_100m; > > > bool is_fiber; > > > bool is_1000basex; > > > + bool tx_lpi_on; > > > > @Andrew, this variable can be replace by your phydev->tx_lpi_enabled > > variable. Should I wait for your patches went mainline? > > I was wondering about the overlap and the best way to address it. > > My patchset is also a bit big, and getting bigger. So it might make > sense to split out some of the bits you need and get them merged > first. > > You need the MAC indicating it is EEE capable. I don't store that > information explicitly, but that is a quick simple change. You also > need phydev->tx_lpi_enabled. Anything else? No. It's fine. Thx! Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists