netdev - Re: [PATCH v3] ptp: add ToD device driver for Intel FPGA cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCL8veyS5xNUMCCt@hoboy.vegasvil.org>
Date:   Tue, 28 Mar 2023 07:42:05 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Tianfei Zhang <tianfei.zhang@...el.com>
Cc:     netdev@...r.kernel.org, linux-fpga@...r.kernel.org,
        ilpo.jarvinen@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
        vinicius.gomes@...el.com, pierre-louis.bossart@...ux.intel.com,
        marpagan@...hat.com, russell.h.weight@...el.com,
        matthew.gerlach@...ux.intel.com, nico@...xnic.net,
        Raghavendra Khadatare <raghavendrax.anand.khadatare@...el.com>,
        Arnd Bergmann <arnd@...nel.org>
Subject: Re: [PATCH v3] ptp: add ToD device driver for Intel FPGA cards


CCing Arnd...

On Tue, Mar 28, 2023 at 10:24:55AM -0400, Tianfei Zhang wrote:

> v3:
> - add PTP_1588_CLOCK dependency for PTP_DFL_TOD in Kconfig file.
> - don't need handle NULL case for ptp_clock_register() after adding
>   PTP_1588_CLOCK dependency.

Sorry, but this isn't how it is done...

> +config PTP_DFL_TOD
> +	tristate "FPGA DFL ToD Driver"
> +	depends on FPGA_DFL
> +	depends on PTP_1588_CLOCK

Try these commands:

   git grep "depends on PTP_1588_CLOCK_OPTIONAL"
   git grep "depends on PTP_1588_CLOCK_OPTIONAL" | grep -v OPTIONAL

Driver must depend on PTP_1588_CLOCK_OPTIONAL and then handle the NULL
case correctly.

Thanks,
Richard