lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230328172445.GA2951931@bhelgaas> Date: Tue, 28 Mar 2023 12:24:45 -0500 From: Bjorn Helgaas <helgaas@...nel.org> To: Dexuan Cui <decui@...rosoft.com> Cc: Saurabh Singh Sengar <ssengar@...rosoft.com>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>, "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Jake Oshins <jakeo@...rosoft.com>, "kuba@...nel.org" <kuba@...nel.org>, "kw@...ux.com" <kw@...ux.com>, KY Srinivasan <kys@...rosoft.com>, "leon@...nel.org" <leon@...nel.org>, "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>, "lpieralisi@...nel.org" <lpieralisi@...nel.org>, "Michael Kelley (LINUX)" <mikelley@...rosoft.com>, "pabeni@...hat.com" <pabeni@...hat.com>, "robh@...nel.org" <robh@...nel.org>, "saeedm@...dia.com" <saeedm@...dia.com>, "wei.liu@...nel.org" <wei.liu@...nel.org>, Long Li <longli@...rosoft.com>, "boqun.feng@...il.com" <boqun.feng@...il.com>, "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [EXTERNAL] [PATCH 1/6] PCI: hv: fix a race condition bug in hv_pci_query_relations() On Tue, Mar 28, 2023 at 05:38:59AM +0000, Dexuan Cui wrote: > > From: Saurabh Singh Sengar <ssengar@...rosoft.com> > > Sent: Monday, March 27, 2023 10:29 PM > > > ... > > > --- > > Please note this special line "---". > Anything after the special line and before the line "diff --git" is discarded > automaticaly by 'git' and 'patch'. > > > > drivers/pci/controller/pci-hyperv.c | 13 +++++++++++++ > > > 1 file changed, 13 insertions(+) > > > > > > @@ -3635,6 +3641,8 @@ static int hv_pci_probe(struct hv_device *hdev, > > > > > > retry: > > > ret = hv_pci_query_relations(hdev); > > > + printk("hv_pci_query_relations() exited\n"); > > > > Can we use pr_* or the appropriate KERN_<LEVEL> in all the printk(s). > > This is not part of the real patch :-) > I just thought the debug code can help understand the issues > resolved by the patches. > I'll remove the debug code to avoid confusion if I need to post v2. I guess that means you *will* post a v2, right? Or do you expect somebody else to remove the debug code? If you do keep any debug or other logging, use pci_info() (or dev_info()) whenever possible. Also capitalize the subject line to match the others in the series. Bjorn
Powered by blists - more mailing lists